Don't notify onError in MakeAsyncHttpRequestStage #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorea
reviewed
Oct 25, 2018
| @@ -128,6 +132,7 @@ private void retryResponseIfNeeded(Response<OutputT> resp, CompletableFuture<Res | |||
| } | |||
|
|
|||
| if (shouldRetry(resp.httpResponse(), resp.exception())) { | |||
| responseHandler.onError(err); | |||
There was a problem hiding this comment.
Can we add a comment about the last error being delivered in the client? That's a bit tricky and not obvious from the code.
dagnir
force-pushed
the
on-error-async-retryable-stage
branch
from
6d122a1 to
1a2e25a
Compare
shorea
approved these changes
Oct 25, 2018
Move the notification back on AsyncRetryable stage so we can decide whether to call onError based on whether we are retrying or not.
dagnir
force-pushed
the
on-error-async-retryable-stage
branch
from
1a2e25a to
3622883
Compare
aws-sdk-java-automation
added a commit
that referenced
this pull request
Apr 1, 2020
…688b224b Pull request: release <- staging/da8c22c4-9478-4be3-af16-8607688b224b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move the notification back on AsyncRetryable stage so we can decide whether to
call onError based on whether we are retrying or not.
Motivation and Context
Fix onError behavior.
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense